-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add target parameter, make it major by default #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
Although it's not enforced in this repo, let's try to stick to conventional commits when committing to this repo. Also stick to shorter commit messages as per git's guidelines (below 50 chars on the first line of the commit). Please rebase and squash commits to make it a single one which adheres to the above. |
Also please modify the workflow file to run linting and testing and make the automerge job depend on it. Inspire from https://github.com/nearform/get-jwks/blob/main/.github/workflows/ci.yml (no need for caching node_modules though). Note the syntax of the npm lint script looks wrong, I think it should be |
the ci workflow should also run on push, not just pull request. can you please make that change too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see inline comments
please rebase on main branch and resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Closes #44
Checklist
npm run test
andnpm run benchmark
and the Code of conduct